Format local dates instead of converting a second time #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
added
[Type] Bug
[Status] Blocked
[Component] Blocks
ryelle
approved these changes
Sep 28, 2020
public_html/wp-content/mu-plugins/blocks/source/blocks/schedule/schedule-grid.js
Outdated
Show resolved
Hide resolved
These dates are _already_ in the site timezone, so `dateI18n()` et al would add the UTC offset a _second_ time. In some cases that would cross a date boundary, and the wrong date would be displayed. Fixes #559
iandunn
force-pushed
the
schedule-heading-yesterday
branch
from
8aecd15 to
dea066c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be merged until we install the version of Gutenberg that includes both WordPress/gutenberg#25083 and WordPress/gutenberg#22866.
Fixes #559
The dates are already in the site timezone, so
dateI18n()et al add the UTC offset a second time. In some cases that would cross a date boundary, and the wrong date would be displayed.